Skip to content

Apply Generated annotation #15150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Apply Generated annotation #15150

merged 1 commit into from
Oct 28, 2025
+567 −33

Conversation

@gustavoharff
Copy link
Contributor

@gustavoharff gustavoharff commented Oct 17, 2025 •
edited
Loading

This PR is the same as apache/grails-data-mapping#1507, but for Grails 7.

Related to #14506, #14364

The only difference to the original PR is the GormEntityDirtyCheckable class, which was created in Grails 7.

@jamesfredley jamesfredley moved this to In Progress in Apache Grails Oct 17, 2025
@gustavoharff
Copy link
Contributor Author

gustavoharff commented Oct 18, 2025 •
edited
Loading

I edited my commit to fix the code style https://github.com/apache/grails-core/actions/runs/18606687610/job/53059843641

I don't know why, but https://github.com/apache/grails-core/actions/runs/18606687662/job/53059843726 has failure, I ran ./gradlew :grails-test-examples-scaffolding:integrationTest local and it worked well.

@jamesfredley
Copy link
Contributor

jamesfredley commented Oct 18, 2025

https://github.com/apache/grails-core/actions/runs/18606687662/job/53059843726 was likely an intermittent failure, since 17 and 21 completed without issue. I reran it to confirm and full CI is running again on latest commit.

@jdaugherty jdaugherty requested a review from matrei October 24, 2025 15:14
jdaugherty
jdaugherty approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@jdaugherty jdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable change. @matrei can you please confirm this is acceptable to merge?

@jamesfredley jamesfredley added this to the grails:7.0.1 milestone Oct 27, 2025
@matrei
Copy link
Contributor

matrei commented Oct 28, 2025

I have some formatting and cleanup for this PR but for some reason I could not push them.
I will create a new PR after this is merged.

@matrei matrei merged commit d860ef7 into apache:7.0.x Oct 28, 2025
36 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache Grails Oct 28, 2025
@gustavoharff gustavoharff mentioned this pull request Nov 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdaugherty jdaugherty jdaugherty approved these changes

@matrei matrei matrei approved these changes

Assignees

@gustavoharff gustavoharff

Labels

None yet

Projects

Apache Grails
Status: Done

Milestone

grails:7.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@gustavoharff @jamesfredley @matrei @jdaugherty